X-From-Line: perl5-porters-return-119177-andreas.koenig.gmwojprw=franz.ak.mind.de@perl.org Thu Dec 14 13:17:26 2006 X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-26) on k75.linux.bogus X-Spam-Level: X-Spam-Status: No, score=-0.2 required=6.1 tests=AWL,BAYES_50 autolearn=no version=3.1.4 X-Spam-Report: * 0.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60% * [score: 0.5000] * -0.2 AWL AWL: From: address is in the auto white-list Received: from lists.develooper.com (x6.develooper.com [63.251.223.186]) by franz.ak.mind.de (8.13.8/8.13.8/Debian-2) with SMTP id kBECH5M9018463 for ; Thu, 14 Dec 2006 13:17:26 +0100 Received: (qmail 10747 invoked by uid 514); 14 Dec 2006 12:16:48 -0000 Mailing-List: contact perl5-porters-help@perl.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: X-List-Archive: List-Id: Delivered-To: mailing list perl5-porters@perl.org Received: (qmail 10709 invoked from network); 14 Dec 2006 12:16:47 -0000 Delivered-To: perl5-porters@perl.org Received-SPF: pass (x1.develooper.com: domain of nick@flirble.org designates 195.40.6.20 as permitted sender) Date: Thu, 14 Dec 2006 12:16:28 +0000 From: Nicholas Clark To: "Andreas J. Koenig" , Tim.Bunce@pobox.com Cc: The Perl5 Porters Mailing List Subject: Re: 29544 breaks X-Gnus-Mail-Source: directory:~/Mail/spool/ Gnus-Warning: This is a duplicate of message <20061214121628.GN6501@plum.flirble.org> Message-ID: <20061214121628.GN6501@plum.flirble.org> Mail-Followup-To: "Andreas J. Koenig" , Tim.Bunce@pobox.com, The Perl5 Porters Mailing List References: <87slfj9l9v.fsf@k75.linux.bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87slfj9l9v.fsf@k75.linux.bogus> User-Agent: Mutt/1.3.25i X-Organisation: Tetrachloromethane Sender: Nicholas Clark X-Saved-For-King: Thu, 14 Dec 2006 13:18:35 +0100 X-Filter: mailagent [version 3.0 PL73] for andreas.koenig@anima.de Lines: 34 Xref: k75.linux.bogus perl5-porters:121782 On Thu, Dec 14, 2006 at 05:03:24AM +0100, Andreas J. Koenig wrote: > >From my favorite CPAN collection 29544 breaks DBI, Params::Validate, and Clone. > > DBI compiles but fails tests: > > t/10examp................ok 1/263Can't DBI::st=HASH(0x8501854)->bind_col(1, SCALAR(0x8480cbc),...), need a reference to a scalar at blib/lib/DBI.pm line 1831. > # Looks like you planned 263 tests but only ran 79. > # Looks like your test died just after 79. > t/10examp................dubious > Test returned status 255 (wstat 65280, 0xff00) > DIED. FAILED tests 80-263 > Failed 184/263 tests, 30.04% okay With the appended patch DBI passes tests on both 5.8.x and blead. Sorry - cooked this up on the train in, but been too busy until now to get it mailed. Nicholas Clark --- DBI.xs~ 2006-10-31 11:59:02.000000000 +0000 +++ DBI.xs 2006-12-14 08:41:18.000000000 +0000 @@ -1435,7 +1435,9 @@ return 1; } - if (!SvROK(ref) || SvTYPE(SvRV(ref)) >= SVt_PVBM) /* XXX LV */ + /* Write this as > SVt_PVMG because in 5.8.x the next type */ + /* is SVt_PVBM, whereas in 5.9.x it's SVt_PVGV. */ + if (!SvROK(ref) || SvTYPE(SvRV(ref)) > SVt_PVMG) /* XXX LV */ croak("Can't %s->bind_col(%s, %s,...), need a reference to a scalar", neatsvpv(sth,0), neatsvpv(col,0), neatsvpv(ref,0));