Name: Redundant up operation in stop_machine.c Signed-off-by: Rusty Russell (authored) Yingchao Zhou noticed that we up() in stop_machine on failure, and also in the caller (unconditionally). Index: linux-2.6.13-rc7-git1-Misc/kernel/stop_machine.c =================================================================== --- linux-2.6.13-rc7-git1-Misc.orig/kernel/stop_machine.c 2005-08-26 11:18:00.000000000 +1000 +++ linux-2.6.13-rc7-git1-Misc/kernel/stop_machine.c 2005-08-26 12:05:01.000000000 +1000 @@ -115,7 +115,6 @@ /* If some failed, kill them all. */ if (ret < 0) { stopmachine_set_state(STOPMACHINE_EXIT); - up(&stopmachine_mutex); return ret; }